Differential D8945

Return a valid bookmark object for any entry in KFilePlacesModel
ClosedPublic
Actions

Authored by renatoo on Nov 22 2017, 2:17 PM.

Tags

Subscribers

ngraham, Frameworks

Details

Reviewers

Commits

R241:531d7759578e: Return a valid bookmark object for any entry in KFilePlacesModel

Summary

Make sure that 'KFilePlacesModel::bookmarkForIndex' return a bookmark
for any item in the model.

Depends on D8944

Test Plan

unit test created

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

renatoo created this revision.Nov 22 2017, 2:17 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 22 2017, 2:17 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

renatoo mentioned this in D8862: Extend KFilePlacesModel API.Nov 22 2017, 2:21 PM

renatoo edited the summary of this revision. (Show Details)Nov 22 2017, 2:23 PM

renatoo added a reviewer: dfaure.

renatoo added a dependency: D8944: Create a 'KFilePlacesModel::refresh' function.

renatoo added a dependent revision: D8946: Avoid unnecessary 'dataChanged' signal.

dfaure accepted this revision.Nov 22 2017, 2:59 PM

This revision is now accepted and ready to land.Nov 22 2017, 2:59 PM

ngraham added a subscriber: ngraham.Nov 22 2017, 4:04 PM

Updated parent brach

Updated parent branch

Updated from master

Parent branch updated

Updated parent branch

Updated parent branch

franckarrecot added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel.Nov 27 2017, 11:16 AM

franckarrecot added a dependent revision: D8450: User can now hide an entire places group from KFilePlacesView.Nov 27 2017, 11:19 AM

Updated parent branch

Closed by commit R241:531d7759578e: Return a valid bookmark object for any entry in KFilePlacesModel (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyNov 27 2017, 1:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/kfileplacesmodeltest.cpp (11 lines)
M			src/filewidgets/kfileplacesmodel.cpp (7 lines)

Diff 22953

autotests/kfileplacesmodeltest.cpp

Loading...

src/filewidgets/kfileplacesmodel.cpp

Loading...