Differential D8590

KPageListView: Update width on font change
ClosedPublic
Actions

Authored by volkov on Nov 1 2017, 12:31 PM.

Details

Reviewers
cfeck
dfaure
rkflx
broulik
wojnilowicz
Commits
R236:525cf0666bc1: KPageListView: Update width on font change
Summary

In particular its font can be changed by Breeze style that
modifies bold fonts to regular when it polishes list views.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volkov created this revision.Nov 1 2017, 12:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 1 2017, 12:31 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
wojnilowicz resigned from this revision.Nov 1 2017, 1:01 PM

I resign because I don't maintain KPageListView.

dfaure accepted this revision.Nov 5 2017, 8:52 PM
This revision is now accepted and ready to land.Nov 5 2017, 8:52 PM
rkflx accepted this revision.Nov 6 2017, 4:17 PM

Since I was added as a reviewer:

  • Tested with KWordQuiz: No app restart necessary anymore to adapt width to changed font.
  • Code looks simple enough and even passes the event to the base class.

Perfect patch, thanks :)

(Minor comment: You could have added some instructions to the test plan, saving me some time.)

Closed by commit R236:525cf0666bc1: KPageListView: Update width on font change (authored by volkov). · Explain WhyNov 7 2017, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpageview_p.h (3 lines)
Msrc/kpageview_p.cpp (9 lines)

Diff 22016

View Options

src/kpageview_p.h

Loading...
View Options

src/kpageview_p.cpp

Loading...