Added setting to toggle drawing of title bar separator
ClosedPublic

Authored by emateli on Oct 18 2017, 7:30 PM.

Details

Summary

Adds a new settings on Breeze theme which allows the user to turn off the title bar separator drawn

Rationale behind this patch:

From what I understand, the separator is seen as a design choice so I won't argue over it, not to mention something like this is entirely subjective.

However, I personally dislike the separator, especially on darker windows. The only way to get rid of it is to either make a custom color scheme for each application so the colors match exactly or run a patched version of breeze (which is what I do). Before using my Breeze patched version I searched on the net on how to remove it, which led me to several threads with other users wanting to toggle it off which is why I make this patch public.

Below are screenshots where the separator is especially noticeable and in my non-design-expert opinion kind of distracting. I think it's a positive addition. Looking forward to your opinions on the matter.

Test Plan
  1. Use default breeze theme
  2. Check the enable/disable the new setting

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
emateli created this revision.Oct 18 2017, 7:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2017, 7:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
emateli added a reviewer: VDG.Oct 18 2017, 7:44 PM
emateli edited the summary of this revision. (Show Details)Oct 18 2017, 7:57 PM
emateli retitled this revision from added setting to toggle drawing of title bar separator to Added setting to toggle drawing of title bar separator.Oct 18 2017, 8:21 PM
emateli edited the summary of this revision. (Show Details)
emateli added a subscriber: Breeze.
januz awarded a token.Oct 19 2017, 1:15 AM

Given this is something that regularly comes up on the Internetz, +1 from me

Ping! Any objections from VDG or anyone else?

ngraham accepted this revision.Oct 22 2017, 8:33 PM

VDG seems MIA. @broulik, I propose we land this in a week or two if nobody else objects.

This revision is now accepted and ready to land.Oct 22 2017, 8:33 PM

I'm going to land this tomorrow if I don't hear anything else.

No objections from me.

I'm going to land this tomorrow if I don't hear anything else.

Would be nice to actually contact the maintainer of the code (and make sure he is among the reviewers) before taking such decisions/actions.
Other than that, feel free to push.
I know there where objections from the VDG about adding too many bikeshedding options to breeze, but since they seem missing in action here, you might as well commit. At this point I do not care any more.

From the VDG's standpoint there is zero reason to block this - as Andy have mentioned above. As for adding options to breeze I didn't know we had anything against it.

I'm going to land this tomorrow if I don't hear anything else.

Would be nice to actually contact the maintainer of the code (and make sure he is among the reviewers) before taking such decisions/actions.

Sorry, I'm still a bit new at this. Would the maintainers would be listed in AUTHORS? If so that would be... you, heh. :P Oops, sorry. I'll remember that in the future.

This revision was automatically updated to reflect the committed changes.