| vkrause |
Use-case: Make building unit tests optional, by just following the CMake
BUILD_TESTING option.
The usual approach to conditionally build tests is to do:
if (BUILD_TESTING)
add_executable(TestOne TestOne.cpp)
target_link_libraries(TestOne my_library)
endif()or:
if (BUILD_TESTING)
add_subdirectory(tests)
endif()This patch just turns all calls to ecm_add_test(...) into no-ops if
BUILD_TESTING=OFF.
See:
https://cmake.org/cmake/help/v3.6/module/CTest.html
| No Linters Available |
| No Unit Test Coverage |
It's not possible to easily disable tests at the moment, is it? I might be missing something.
Anyhow, this patch tries to make it easy to build KDevelop without tests; trying to avoid hacky approaches like those being done in Gentoo:
https://bugs.gentoo.org/show_bug.cgi?id=627242
In ecm_mark_as_test (which is used in ecm_add_test) we already disable the target if BUILD_TESTING is false, why is that not enough?
Good question. I didn't explain that in the commit message:
ecm_add_test also invokes target_link_libraries(...) which may pull in additionally dependencies if BUILD_TESTING=ON.
Example:
ecm_add_test(test_svnrecursiveadd.cpp LINK_LIBRARIES
Qt5::Test Qt5::Gui
)This patch actually makes it pretty easy to get rid off the Qt5::Test dependency in a whole KDE project without touching lots of CMake code.
+1 as well. Please also add a note in the API dox what BUILD_TESTING will do on this macro, so this is not magic behaviour and people can plan with this (like making sure to not set target_link_libraries(... Qt5::Tests) separately, but only pass as args in the macro *cough*kdevelop*cough*)