| mart |
We don't need to manually start the DBus service.
It blocks the calling app, and dbusServiceExists means that we will
always end up going the DBus route over a popup anyway, so it won't
do anything useful.
The service (in the plasma case plasma-wait-for-name) will be started
automatically when we actually send the notification.
BUG: 382444
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Removing this call is in line with the advice in the dbus spec.
An improvement to the patch would be to remove bool startfdo.
Q_WS_WIN seems to suggest that windows always needs to start the service manually. That case would break with this patch.
Remove startFdo flag
Keep windows away from DBus activation
Better handle the service owner changing on a potentially
DBus activated notification handler
The patch looks clean, but I do not fully understand how is supposed to work. Perhaps an explanation of the different scenarios would help future readers of this code.