Differential D6762

ECM: KDECompilerSettings LINKER_FLAGS on Cygwin
ClosedPublic
Actions

Authored by winterz on Jul 17 2017, 10:18 PM.

Details

Reviewers
skelly
kfunk
Group Reviewers
Build System
Windows
Summary

Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to 'ld'
else you get /usr/lib/gcc/x86_64-pc-cygwin/5.4.0/../../../../x86_64-pc-cygwin/bin/ld: unrecognized option '--enable-new-dtags'

Test Plan

see if I can build something on cygwin now

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Jul 17 2017, 10:18 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJul 17 2017, 10:18 PM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
nalvarez added a subscriber: nalvarez.Jul 18 2017, 2:23 AM

Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin...

kfunk accepted this revision.Jul 18 2017, 8:00 AM
This revision is now accepted and ready to land.Jul 18 2017, 8:00 AM
winterz added a comment.Jul 18 2017, 12:16 PM
In D6762#126463, @nalvarez wrote:

Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin...

fun. as an experiment. i'm curious.

Revision Contents
Changeset List

Diff 16850

View Options

kde-modules/KDECompilerSettings.cmake

Loading...