build: Remove KService dependency
ClosedPublic

Authored by palokisa on Apr 24 2017, 6:49 AM.

Details

Summary

..as it's not used anywhere (and the KService isn't some kind of
"selfinitializing" library, that only needs to be linked to).

Diff Detail

Repository
R268 KGlobalAccel
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
palokisa created this revision.Apr 24 2017, 6:49 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 24 2017, 6:49 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
graesslin accepted this revision.Apr 24 2017, 4:16 PM
This revision is now accepted and ready to land.Apr 24 2017, 4:16 PM

Sorry, I'm not familiar with the phabricator process... should I take some action now?

apol edited edge metadata.Apr 24 2017, 6:12 PM

Yes, do you have commit/push access? Otherwise we'll push it ourselves.

palokisa added a comment.EditedApr 24 2017, 6:53 PM
In D5556#104466, @apol wrote:

Yes, do you have commit/push access? Otherwise we'll push it ourselves.

As I don't know, what you are talking about... probably not

This revision was automatically updated to reflect the committed changes.
bcooksley reopened this revision.Apr 26 2017, 7:58 AM
bcooksley added a subscriber: bcooksley.

Reopening as the commit has been removed via force push per T5958

This revision is now accepted and ready to land.Apr 26 2017, 7:58 AM

What's happening here? :)

There was a mistake made when committing this which Luigi and Aleix wanted to fix.
The patch itself is fine and does not require any changes - one of them should re-land this patch soon.

What's happening here? :)

Palo, can you please share your email (here, if you don't mind it being public, or to me on IRC (tosky) or to mail email address luigi dot toscano attheserver tiscali dot it ?

This revision was automatically updated to reflect the committed changes.