@davidedmundson
While looking at the implementation here... would you accept using RAII here? Something like:

diff
diff --git a/core/polkitqt1-identity.cpp b/core/polkitqt1-identity.cpp
index 9af489e..90e4a3d 100644
--- a/core/polkitqt1-identity.cpp
+++ b/core/polkitqt1-identity.cpp
@@ -21,6 +21,7 @@
 #include "polkitqt1-identity.h"

char -> gchar

What's happening here? :)

In D5556#104466, @apol wrote:

Yes, do you have commit/push access? Otherwise we'll push it ourselves.

Sorry, I'm not familiar with the phabricator process... should I take some action now?

In D5521#103810, @graesslin wrote:

The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData.

In D5521#103775, @cfeck wrote:

Btw, libKF5GlobalAccel is actually Tier1, so applications needing global shortcuts will not have any (additional) KF5 dependencies, only the runtime has.

What is KF5::Service used for? You don't seem to be #ifdef it. Maybe it's not needed at all?

I don't know. I didn't investigate that.....I thought, it's some kind of "self-initializing" component and it is enough to link the library.

I don't think it's the case for KService (it is for KCrash though). Please investigate (or wait for feedback).

Then I believe, it's only some remnant, because it's not used anywhere in the code.

The obvious reason is that it would be impossible to install frameworks and lxqt at the same time.

Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE

In D5521#103536, @apol wrote:

In D5521#103535, @palokisa wrote:

Make them optional dependencies.

What do you mean by this?

find_package(KF5Crash) #note there's no REQUIRED
if (KF5Crash_FOUND)
    somethingsomething()
endif()

Make them optional dependencies.