Differential D5136

Introduce fetch-translations build command
AbandonedPublic
Actions

Authored by apol on Mar 22 2017, 6:53 PM.

Details

Reviewers
aacid
sitter
kfunk
Group Reviewers
Frameworks
Build System
Summary

Makes it possible to fetch translations when building the project. To do so
it fetches kde:releaseme and uses the new fetchpo.rb program to download the
translations into the build directory.

This should make it much easier to integrate translations in the development
process.

Test Plan

Used successfully with a couple of projects

Diff Detail

Repository
R249 KI18n
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 22 2017, 6:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2017, 6:53 PM
kfunk added inline comments.Mar 22 2017, 7:14 PM
KF5I18nConfig.cmake.in
12

Can you delay that git invocation to when the custom target is executed? Otherwise we also pay for this whenever KF5I18nConfig.cmake is included

17

Style: Remove newline

24

git clone --depth 0 ...?

30

--origin stable being hard-coded doesn't look right

kfunk requested changes to this revision.Mar 22 2017, 7:14 PM
This revision now requires changes to proceed.Mar 22 2017, 7:14 PM
apol marked 2 inline comments as done.Mar 22 2017, 9:34 PM
apol updated this revision to Diff 12705.Mar 22 2017, 9:35 PM
apol edited edge metadata.

Address some issues

aacid edited edge metadata.Mar 22 2017, 10:25 PM

I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest.

This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all.

Maybe it would make more sense in some of the *KDE* files ECM has?

kfunk added a comment.Mar 22 2017, 10:42 PM
In D5136#96878, @aacid wrote:

I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest.

This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all.

Maybe it would make more sense in some of the *KDE* files ECM has?

Exactly what I told apol on IRC, too ;)

apol added a comment.Mar 22 2017, 10:57 PM
In D5136#96878, @aacid wrote:

I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest.

This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all.

Maybe it would make more sense in some of the *KDE* files ECM has?

Maybe. My thinking was that we'll have to find ki18n anyway and ECM is already a dependency of ki18n. I can move it there, no problem.

ltoscano added a subscriber: ltoscano.Mar 22 2017, 11:10 PM

I agree that it should go to ECM, and there are modules (for various reasons) with translations not handled by KI18n.

Revision Contents
Changeset List

PathPackages
MKF5I18nConfig.cmake.in (41 lines)

Diff 12705

View Options

KF5I18nConfig.cmake.in

Loading...