| emmanuelp |
| VDG | |
| Dolphin |
When inside a place, the address bar already gives it precedence over the actual folder name.
By doing this in the title bar also, we make it consistent and can mask ugly technical terminology like "trash:/" and instead show the nice localized "Trash" place name as well as "Home" instead of lowercase internal user name.
BUG: 211959
I explicitly opted not to show the scheme for places for the Trash and also if you explicitly made it a place, you probably knew (or don't even care) what it is technically using. A downside is when you have multiple similar devices (120 GiB removable drive) you cannot tell them apart from the address bar but you'd have a hard time in other places anyway.
Behavior of "Show full path in title bar" is unchanged, always showing the full address (e.g. /home/foo/bar, or smb - foo - /foo/bar)
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I think that's a good change from UX point of view.
Regarding the test plan:
if
shouldn't this
be
At least that's what dolphin does in other places
+1, please add this bug to the commit message: https://bugs.kde.org/show_bug.cgi?id=211959
Nice feature :)
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 962 | I think it would be better to create a new (static) places model instance instead of exposing (even more) implementation details of the view container. This would allow us to reuse this code for the tab titles (by moving it to global.h) without retouching the implementation. | |
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 962 | Where should I put the static fileplacesmodel? | |
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 962 | Static local variable. | |
Is there a reason why Konqueror is added in CC of all dolphin merge requests? Is that done manually or automatically? I don't see the relevance for konqueror, especially for a patch for DolphinMainWindow (no effect on dolphinpart).
It is done automatically, I don't know who requested the rule; the reason is maybe the dolphinpart. Anyway, the rule was created last April and it says:
When all of these conditions are met: Repository projects include any of Dolphin, Konqueror Take these actions every time this rule matches: Add subscribers: Dolphin, Konqueror.
The rule can be changed/tuned.