| mwolff | |
| apol |
| KDevelop |
In the revision D4686 Aleix Pol suggests to split source code and run-time analyzers. Runtime checkers now already moved to the "Run" menu (revison D4914).
This patch makes second step to implement "split idea" - code-checkers (Cppcheck/Clang-Tidy/Vera++/etc) now are moved to the "Code" menu (this fixes will be pushed to upstream after the revision acceptance).
The patch requires D5043 applied to kdevplatform.
Tested with master branch and Cppcheck/Clang-Tidy/Vera++ plugins.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| analyzers/cppcheck/plugin.cpp | ||
|---|---|---|
| 60–69 | Could this action text (and similar for the other checks) be reduced to just "Cppcheck", like done with the context actions? What was the motivation to have different menu texts and thus QAction objects? | |
| 78 | See first comment. | |
| app/kdevelopui.rc | ||
| 111 | Given the comment above. this here then would be "Analyze Current File With" | |
| 115 | s.a. | |
| analyzers/cppcheck/plugin.cpp | ||
|---|---|---|
| 60–69 |
Name reduction will be great at menu but then we will have two actions with same name but with different mean (file/project analysis) in shortcuts editor :( Do you have an ideas how to fix this with "right way"? | |
Not right now, see kxmlgui/src/kshortcutseditoritem.cpp:54
m_actionNameInTable = i18nc([...] KLocalizedString::removeAcceleratorMarker(m_action->text()));
which is returned further down as DisplayRole for the Name column.
But you could easily add support for a custom property here ("descriptiveText") and document that, it would certainly be useful for all those actions whose text only makes sense in the context of the submenu they're in.
Hi, David. Thanks for your answer. Your suggestion is good, I'll try to present patch for this later.
2 all: Thanks for your review. I suggest to use this revision as base and push it to upstream. Then I will work with new patch to kdelibs to add support for custom text for shortcuts editor item and after acceptance and pushing to master we can add compile-time checks for kdelibs version to enable this functionality in cppcheck plugin. Your opinions?