Reorganize "Run" menu
ClosedPublic

Authored by antonanikin on Mar 3 2017, 10:09 AM.

Details

Summary

The patch reorganize "Run" menu to more consistent view. In the revision D4686 Aleix Pol suggests to split source code and run-time analyzers. This patch makes first step to implement this idea - runtime-checkers (Valgrind and Heapcheck) now are moved to the "Run" menu (this fixes will be pushed to upstream after the revision acceptance).

Test Plan

Tested with master branch and valgrind/heaptrack plugins.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin created this revision.Mar 3 2017, 10:09 AM
antonanikin edited the summary of this revision. (Show Details)Mar 3 2017, 10:10 AM
mwolff added a subscriber: mwolff.Mar 5 2017, 10:07 PM

lgtm in principle, but I find it odd that to is lower-cased, but With is uppercased

debuggers/common/midebuggerplugin.cpp
87

hm should the To also be upper-cased? can you ask the HIG?

For actual readability, it would be much nicer to have both lowercased than uppercased.

The HIG agrees:

Do not capitalize:

Articles: a, an, the
Coordinating Conjunctions: and, but, or, for, nor, etc.
Prepositions (fewer than five letters): on, at, to, from, by, etc.
antonanikin updated this revision to Diff 12218.Mar 6 2017, 1:47 AM
  • Lowercase for "with"

@flherne, thanks for HIG reference.

genaxxx added a subscriber: genaxxx.Mar 6 2017, 7:21 AM
kfunk accepted this revision.Mar 7 2017, 8:52 PM
kfunk added a subscriber: kfunk.

LGTM

This revision is now accepted and ready to land.Mar 7 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.