share, added activity configuration
share, added dataset 1
share, added multiple datasets
echarruau | |
jjazeix | |
timotheegiet | |
AkshayCHD |
share, added activity configuration
share, added dataset 1
share, added multiple datasets
No Linters Available |
No Unit Test Coverage |
Buildable 27138 | |
Build 27156: arc lint + arc unit |
src/activities/share/Share.qml | ||
---|---|---|
245 | Increased left widget size, to fit double digit numbers of candy | |
src/activities/share/share.js | ||
119 | Previously for non randomised levels, Instructions show how many candies child needs to distribute while for random levels instructions shows total no. of candies without considering placed in candies. |
More globally, do we need to specify how many children are girls or boys?
"Paul wants to equally share 2 pieces of candy between 2 of his friends: one girl and one boy." -> is there any addition of knowing there is a boy and a girl?
src/activities/share/ActivityConfig.qml | ||
---|---|---|
52 | indentation | |
src/activities/share/resource/1/Data.qml | ||
35 | why is it a string and not a boolean? | |
62 | missing dot at the end of the sentence | |
86 | Shouldn't there be no rest on the first dataset? | |
97 | should be no rest? | |
154 | missing . | |
176 | missing . | |
290 | rest? | |
301 | rest? | |
src/activities/share/resource/2/Data.qml | ||
24 | to be discussed, but if the objective says there is a rest, I don't see any rest in some levels. | |
34–35 | bool | |
73 | 11-2 = 9 :) | |
211 | four boys and one girl. | |
222 | candy | |
268 | two girls and two boys |
"Paul wants to equally share 2 pieces of candy between 2 of his friends: one girl and one boy." -> is there any addition of knowing there is a boy and a girl?
If you only take the aim to teach "sharing" there is no addition interest of knowing that there is a boy and a girl.
But solving problem is also a matter of taking multiple informations, deciding if they are important or not, keeping only the relevant ones.
Here it is interesting to add a bit of difficulties which is placing a girl and a boy and not only two boys.
We have the beginning of what we call a multiple phases problem.
After discussion I think that this should be proposed after a first level that proposes only boys or girls. Sharing is the main goal we are aiming at here.
@shubham: could you please make some modifications to be sure that the first questions of each level have only girls and no boys?
src/activities/share/resource/1/Data.qml | ||
---|---|---|
24 | Can't we make it simply "Split candies equally between kids with no extra candies left." | |
src/activities/share/resource/2/Data.qml | ||
24 | I think a better objective would be "Split candies equally between kids with extra candies may or may not be left." | |
src/activities/share/resource/3/Data.qml | ||
24 | Again this can be reduced to "Split candies equally between kids." |
src/activities/share/Share.qml | ||
---|---|---|
65 | What is the purpose of this check, as in the share.js file we are not making any checks based on the case when the value of levels is null. |
src/activities/share/Share.qml | ||
---|---|---|
65 | nothing specific, just to make this line the same across all activities but yes, we don't need this check here. So removing it. |
For the datasets descriptions, I think it would be more efficient to make it shorter and to the point, something like:
"Maximum n candies and n kids, no rest.", "Maximum n candies and n kids, possible rest.".... (replacing n with the actual values of course)
Played it extensively. Could not break and I find the new dataset messages much clearer.
Good for me.
We have 2 conflicting options for the "show counter"... If we set it on the configuration, I would expect to always have it but on some level, we have an attribute: "showCount" which overrides the configuration option. @timotheegiet, @echarruau I think it was already previously the case but it may be better to find a better wording of the option if we want to keep this behaviour?
waiting for @timotheegiet to validate the diff so we can close it. Once done, @shubhammishra please close the diff and the related tasks.
Commited in https://invent.kde.org/education/gcompris/-/commit/1f616fbdf03f594ded8ab4631805ced9f42ed75c
Thank you!
Indeed, looks like I overlooked this.
And, the "showCount" in datasets doesn't exactly override the config option, as if the config says to not show it, it will not show it even if dataset says to show it (so, if any of the config or the dataset says to not show, it won't show it).
After thinking more about it, for default datasets, I think we should not use the "showCount" in datasets and only rely on the config option to show/hide it.
It would be good to still have this variable available for teachers if they need to specify it per custom dataset; but then this dataset-variable should really override the config option in any case.
Either this, or just remove the config option and only use the dataset variable to handle it.
I confirm my first idea from previous comment: better keep the "show counter" as an Option, and not part of the datasets.
(similar to the comment I just made for categorization on https://phabricator.kde.org/T13112 )
Hi,
The "showCount" in datasets and "show counter" option in config behaves differently. When we disable counter from config, "totalCandies" becomes invalid and it is possible to drag unlimited candies that also means candies never become unavailable. I thought it was intended not a bug so didn't raise this before.
I checked the code and now I can say it is intended because of line 305 in Share.qml
total: background.easyMode ? items.totalCandies : 8 * items.totalChildren + 1
Maximum limit of candies in any box is 8. Now, the question is, do we really want behavior like this or not?
For consistency, as we already always limit the number of boys/girls to place according to the numbers in the instructions, it would be logical to do the same for the number of candies.
So, unless others disagree, I think we don't really want this behavior, and it can be changed.