Differential D29568

use KSycoca for updating OpenPreferredSearchTool action
ClosedPublic
Actions

Authored by pdabrowski on May 9 2020, 2:40 PM.

Details

Reviewers
broulik
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Commits
R318:29e6cf01df75: use KSycoca for updating OpenPreferredSearchTool action
Summary

Remove all random updates of OpenPreferredSearchTool action, and
use KSycoca for updating it as discussed in https://phabricator.kde.org/D22594#663847

Enhancement for D29441 for bug #420911 caused by D22594.
The bug was fixed by D29442.

CCBUG: 420911

Test Plan
$ cd ${KDE_INSTALL_DIR}/usr/share/applications

$ sudo mv org.kde.kfind.desktop org.kde.kfind.desktop_
$ kbuildsycoca5

$ sudo mv org.kde.kfind.desktop_ org.kde.kfind.desktop
$ kbuildsycoca5

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
pdabrowski created this revision.May 9 2020, 2:40 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 9 2020, 2:40 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
pdabrowski requested review of this revision.May 9 2020, 2:40 PM
anthonyfieroni added a subscriber: anthonyfieroni.May 9 2020, 3:48 PM
anthonyfieroni added inline comments.
src/dolphinmainwindow.cpp
209

Use new connect syntax.

pdabrowski updated this revision to Diff 82388.May 9 2020, 5:31 PM
pdabrowski marked an inline comment as done.May 9 2020, 5:34 PM
pdabrowski added inline comments.
src/dolphinmainwindow.cpp
209

Done.

Also using signal:

void databaseChanged();

instead of:

void databaseChanged(const QStringList &changedResources); // KF6: deprecate
pdabrowski marked 2 inline comments as done.May 9 2020, 5:35 PM
pdabrowski edited the summary of this revision. (Show Details)May 21 2020, 8:40 PM
pdabrowski edited the summary of this revision. (Show Details)
pdabrowski edited the summary of this revision. (Show Details)May 21 2020, 8:44 PM
pdabrowski edited the test plan for this revision. (Show Details)May 21 2020, 8:46 PM
elvisangelaccio accepted this revision.May 23 2020, 9:41 PM

Not sure if this should go to release/20.04, but I guess it shouldn't hurt.

This revision is now accepted and ready to land.May 23 2020, 9:41 PM
Closed by commit R318:29e6cf01df75: use KSycoca for updating OpenPreferredSearchTool action (authored by pdabrowski, committed by ngraham). · Explain WhyMay 24 2020, 2:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.h (8 lines)
Msrc/dolphinmainwindow.cpp (35 lines)

Diff 82377

View Options

src/dolphinmainwindow.h

Loading...
View Options

src/dolphinmainwindow.cpp

Loading...