Differential D28920

Adapt to changes in KBookmarks >= 5.69
ClosedPublic
Actions

Authored by ahmadsamir on Apr 17 2020, 1:58 PM.

Details

Reviewers
cfeck
uwolfer
murrant
Commits
R436:3da2ea6ea36c: Adapt to changes in KBookmarks >= 5.69
R436:70e9d2728a49: Adapt to changes in KBookmarks >= 5.69
Test Plan

The Bookmarks menu is still added as expected and the actions still show
in the configure shortcuts dialog. I couldn't test actually creating a
bookmark as I have no access to remote servers.

Diff Detail

Repository
R436 KRDC
Branch
l-kbookmarkmenu (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25376
Build 25394: arc lint + arc unit
ahmadsamir requested review of this revision.Apr 17 2020, 1:58 PM
ahmadsamir created this revision.
cfeck added a comment.Apr 17 2020, 4:45 PM

Was the API change actually required to fix a bug? I don't see an "Edit Bookmarks..." menu item in KCharSelect, Dolphin, or Konqueror (see bug 418666) and I guess that any other user of that API suddenly got broken, which seem against our API stability promises.

ahmadsamir added a comment.Apr 17 2020, 5:30 PM

The API change was in D25660, basically removing the KActionCollection dep (and hence KXMLGui) from KBookmarks.

AFAIK you need to have keditbookmarks installed for the "Edit Bookmarks" menu action to show at all. I don't know where exactly that condition exists in the code, but I know that while testing yesterday I had to install keditbookmarks :). I'll update the bug report.

cfeck added a comment.Apr 17 2020, 5:34 PM

Ouch, you are right, I had removed keditbooks some time ago for testing something.

cfeck accepted this revision.Apr 17 2020, 5:41 PM
This revision is now accepted and ready to land.Apr 17 2020, 5:41 PM
Closed by commit R436:70e9d2728a49: Adapt to changes in KBookmarks >= 5.69 (authored by ahmadsamir). · Explain WhyApr 17 2020, 5:44 PM
This revision was automatically updated to reflect the committed changes.
asturmlechner added a subscriber: asturmlechner.Apr 17 2020, 7:15 PM

This should be in release/20.04 branch as well *imo*.

ahmadsamir added a comment.Apr 17 2020, 7:38 PM
In D28920#650634, @asturmlechner wrote:

This should be in release/20.04 branch as well *imo*.

Based on D28789, this is OK IIUC, so I've just cherry-pick'ed this to release/20.04 (I hope that's OK).

Revision Contents
Changeset List

PathPackages
Mbookmarkmanager.cpp (7 lines)

Diff 80389

View Options

bookmarkmanager.cpp

Loading...