Decouple KBookmarksMenu from KActionCollection
Needs ReviewPublic

Authored by nicolasfella on Sun, Dec 1, 4:56 PM.


Group Reviewers
Maniphest Tasks
T12056: KBookmarks

The usage of KActionCollection makes KBookmarks depend on KXMLGui. To allow to get rid of this rather heavy dependency for KF6 a new constructor is introduced that does not take a KActionCollection. Instead apps that use KBookmarksMenu and KXMLGui are encouraged to manually add the relevant actions to their action collection. It's not pretty, but better than depending on KXMLGui, especially given that KIO depends on KBookmarks and thus on KXMLGui.

Test Plan

Tested with patched Dolphin (new constructor is used) and unpatched Konsole.

Diff Detail

R294 KBookmarks
No Linters Available
No Unit Test Coverage
Build Status
Buildable 19353
Build 19371: arc lint + arc unit
nicolasfella created this revision.Sun, Dec 1, 4:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Dec 1, 4:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sun, Dec 1, 4:56 PM
apol added a subscriber: apol.Sun, Dec 1, 5:21 PM

Maybe this is too of an intermediate step? this patch doesn't really do anything.

nicolasfella planned changes to this revision.Sun, Dec 1, 5:35 PM

I can do it with the rest of the patch

  • Decouple from KActionCollection
nicolasfella retitled this revision from Add member for editbookmarks action to Decouple KBookmarksMenu from KActionCollection.Sun, Dec 1, 8:48 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the test plan for this revision. (Show Details)