Replace Vokoscreen with VokoscreenNG
ClosedPublic
Actions

Authored by harogaston on Mar 29 2020, 7:02 AM.

Details

Reviewers

ngraham
leinir

Group Reviewers

KNewStuff

Commits

R304:5613fd66c5f4: Replace Vokoscreen with VokoscreenNG

Summary

The original Vokoscreen project has been abandoned
and superseeded by VokoscreenNG. This patch updates
the references.

BUG: 416460
FIXED-IN: 5.70

Test Plan

Spectacle -> Tools -> Record Screen the new
VokoscreenNG entry should appear and the new
website referenced. (If other tools are installed
it will appear under "More")

Diff Detail

Repository

R304 KNewStuff

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

harogaston created this revision.Mar 29 2020, 7:02 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 29 2020, 7:02 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

harogaston requested review of this revision.Mar 29 2020, 7:02 AM

Harbormaster completed remote builds in B24409: Diff 78778.Mar 29 2020, 7:02 AM

harogaston edited the summary of this revision. (Show Details)Mar 29 2020, 7:05 AM

harogaston edited the test plan for this revision. (Show Details)

harogaston added reviewers: KNewStuff, ngraham.

harogaston edited the summary of this revision. (Show Details)

It seems that of released distros, only Fedora has vokoscreenNG in repositories so far

In D28397#637193, @IlyaBizyaev wrote:

It seems that of released distros, only Fedora has vokoscreenNG in repositories so far

It's in the AUR also https://aur.archlinux.org/packages/vokoscreen (don't be mislead by the name, it is the new version) but I can see your point.

PS: It will also be in Ubuntu 20.04 LTS, CentOS 8, Debian Sid. I just did a quick search https://pkgs.org/search/?q=vokoscreen

It's also in openSUSE Tumbleweed, FWIW--where it's replaced the old Vokoscreen entirely.

Since the newer distros that will get a new KNewStuff are also going to be the ones that are the most likely to be packaging the new version, I think it makes sense to do this--the only question is the timing. Do it now, or wait a month or two or three? Doing it now makes sense to me since the distros that don't yet have VokoscreenNG probably will by the time they update to Frameworks 5.59. It's always annoying when apps do this kind of thing, but we need to adapt IMO.

Thoughts?

This revision is now accepted and ready to land.Mar 30 2020, 4:49 AM

please do not change translated keys (eg Name[lang]) in desktop-alike files when you change the English string: we have a system in place to handle translations

In D28397#637602, @pino wrote:

please do not change translated keys (eg Name[lang]) in desktop-alike files when you change the English string: we have a system in place to handle translations

Do I need to address this or is it a recommendation? I had no idea about that, soory.

In D28397#638434, @harogaston wrote:

In D28397#637602, @pino wrote:

please do not change translated keys (eg Name[lang]) in desktop-alike files when you change the English string: we have a system in place to handle translations

Do I need to address this or is it a recommendation? I had no idea about that, soory.

Just change the Name= part, the rest will get automatically repopulated by magical CI scripts.

Removed unnesessary changes to .desktop as indicated

Harbormaster completed remote builds in B24656: Diff 79185.Apr 3 2020, 3:07 AM

Thanks! I will commit this tomorrow after branching as we don't typically change translated strings within two weeks of branding, so as to give the translators time to translate them.

ngraham edited the summary of this revision. (Show Details)Apr 3 2020, 3:21 PM

Closed by commit R304:5613fd66c5f4: Replace Vokoscreen with VokoscreenNG (authored by harogaston, committed by ngraham). · Explain WhyApr 7 2020, 6:31 PM

This revision was automatically updated to reflect the committed changes.

Great patches, @harogaston! Keep 'em coming! :)

In D28397#643937, @ngraham wrote:

Great patches, @harogaston! Keep 'em coming! :)

Yes, quarantine is working good for me ;).
I've also got a couple of PRs on Konsole.
Thank you for your work and support @ngraham !

You're welcome!

Revision Contents
Changeset List

			Path	Packages
M			data/kmoretools-desktopfiles/_update_all_files.sh (4 lines)
V			data/kmoretools-desktopfiles/{vokoscreen.desktop → vokoscreenNG.desktop}
V			data/kmoretools-desktopfiles/{vokoscreen.png → vokoscreenNG.png}
V			data/kmoretools-desktopfiles/{vokoscreenNG.desktop ← vokoscreen.desktop} (6 lines)
V			data/kmoretools-desktopfiles/{vokoscreenNG.png ← vokoscreen.png}
M			src/kmoretools/kmoretoolspresets.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78778	7d6db88		Mar 29 2020, 7:02 AM	★	★
Diff 2	79185	7d6db88	Removed unnesessary changes to .desktop as indicated	Apr 3 2020, 3:07 AM	★	★
Diff 3	79611	37452d0	R304:5613fd66c5f42c8acdcb72586292e5fd9346e7b3	Apr 7 2020, 6:30 PM	★	★