Details
- Reviewers
davidedmundson zzag bport ervin apol - Group Reviewers
KWin - Commits
- R108:564c739371c8: Wayland: Allow to set a scroll Factor for input devices
build, ctest, manual set of scrollfactor value via qdbusviewer
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
We follow libinput maintainer opinion https://gitlab.freedesktop.org/libinput/libinput/issues/185 that the platform (or the toolkit) should implement this.
(sway compositor implements this https://github.com/swaywm/sway/pull/3018/files#diff-40846134db734aabaf9eb9e98bccab5eL1005)
It is an open issue for gnome https://gitlab.gnome.org/GNOME/gtk/issues/1308
We might want to let some apps the real "untouched" events, we could allow a "X-KWin-No-ScrollFactor" in their service file for instance.
| libinput/events.cpp | ||
|---|---|---|
| 217 | Why not this one? | |
Should I add a "supportScrollFactor" bool to make it easier of the UI side ?
By UI side you mean the KCM?
Yes, but nevermind, those KCM Uis are already split X/Wayland so I don't need it for this use case actually.
Seems fine to me it's analogous to a touchpad input matrix, which are also done server side.
I believe Vlad had a concern, I do want to hear what that is before approving.
| libinput/device.cpp | ||
|---|---|---|
| 315 | There is type erasure and implicit conversion involved so I guess it ends up working properly in practice, still I'd advise using "1.0" here which would be of the right type. Just a question of making intent obvious. | |
| libinput/device.h | ||
| 335 | s/ScrollFactorDefault/scrollFactorDefault/ | |
First of all, thanks for integrating this into KDE, can't wait to test when it ships with a more stable build.
Just a short note, there is also another, more specific issue for this on GNOME: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/379