Relates to D25010
- Group Reviewers
- R241:36038b904f68: Add "Stat" prefix to StatDetails Enum entries
This is a weird way of doing this.
A C-style enum is used like KIO::StatBasic.
I suggest to pick one of those two solutions and stick to it:
The current patch makes it look like StatBasic is in the StatDetail "namespace" when in fact it's not.
I would rather use C++ enum class but it would require to add some shenanigans since I use currently the enum as a bit map, complicating code and a Q_Flag.
Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/
I like it a lot more, this adds quite a lot of type safety.