Relates to D25010
Details
- Reviewers
kossebau dfaure - Group Reviewers
Frameworks - Commits
- R241:36038b904f68: Add "Stat" prefix to StatDetails Enum entries
Builds
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/core/global.h | ||
---|---|---|
322 | Is this change source-compatible? |
src/core/global.h | ||
---|---|---|
322 | I think this enum was not released yet |
src/core/statjob.cpp | ||
---|---|---|
106 | This is a weird way of doing this. A C-style enum is used like KIO::StatBasic. I suggest to pick one of those two solutions and stick to it:
The current patch makes it look like StatBasic is in the StatDetail "namespace" when in fact it's not. |
src/core/statjob.cpp | ||
---|---|---|
106 | I would rather use C++ enum class but it would require to add some shenanigans since I use currently the enum as a bit map, complicating code and a Q_Flag. |
Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/
I like it a lot more, this adds quite a lot of type safety.
Maybe this could be part of KF6 adding the macros to have enum class used a bitmask and as much as possible enums ported to those enum class.