Make Pin buttons consistently sized in System Tray and Clock pop-ups
ClosedPublic

Authored by ngraham on Mon, Mar 23, 5:30 AM.

Details

Summary

The Pin buttons in the System Tray and Clock pop-ups are very small. This has
always felt slightly odd to me, and the recent change to add a defined header
area for the System Tray pop-up makes it even odder in my opinion, as the icon
is now much smaller than the area it visibly inhabits. This patch makes both icons
in both applets use the standard size with no local overrides. The clock pop-up's
pin button is ported to PC3 in the process.

Depends on D28228

Test Plan

Before:


After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mon, Mar 23, 5:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Mar 23, 5:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Mar 23, 5:30 AM
ognarb accepted this revision.Mon, Mar 23, 8:33 AM
ognarb added a subscriber: ognarb.

+1 for using standard size instead of using an hardcoded size.

This revision is now accepted and ready to land.Mon, Mar 23, 8:33 AM


Gets pretty large here, surely bigger than small icon size. Maybe another PlasmaComponents 3 issue?

The size is actually perfect for being a ToolButton:

However yeah, the actual icon size in a ToolButton is smallMedium, so I guess the fact that you need to use small to get the right size is an issue with the component.

ndavis added a subscriber: ndavis.Mon, Mar 23, 4:38 PM

The size is actually perfect for being a ToolButton:

However yeah, the actual icon size in a ToolButton is smallMedium, so I guess the fact that you need to use small to get the right size is an issue with the component.

If that's the case, is this actually the right fix to do? Or will this patch be updated after the PC3 ToolButton is fixed?

ngraham added a subscriber: mart.EditedMon, Mar 23, 4:48 PM

The PC3 ToolButton has been "fixed" half a dozen times already and I imagine poor @mart is thoroughly sick of it by now...

However even if the sizing is fixed, we'd still need a patch to change the current code to *something* (even if that something is removing all the existing size override code because the default sizing finally works).

mart added a comment.Mon, Mar 23, 5:00 PM

if the size of that button changes in systray, it muct change in calndar too

mart requested changes to this revision.Mon, Mar 23, 5:11 PM

wait, if you mean that you want the pin button with 22x22px icon size, this patch is not correct and it should have no size parameters

This revision now requires changes to proceed.Mon, Mar 23, 5:11 PM
mart added a comment.Mon, Mar 23, 5:22 PM

icon comes from plasma theme, which is

it needs padding

ngraham updated this revision to Diff 78300.Mon, Mar 23, 5:26 PM

Remove all size overrides; the problem is in the Plasma theme icon having no padding and will be fixed there in a different patch

ngraham retitled this revision from [applets/systemtray] Make Pin button a bit larger to Make Pin buttons consistently sized in System Tray and Clock pop-ups.Mon, Mar 23, 5:41 PM
ngraham edited the summary of this revision. (Show Details)
mart accepted this revision.Mon, Mar 23, 5:42 PM
This revision is now accepted and ready to land.Mon, Mar 23, 5:42 PM
ngraham edited the summary of this revision. (Show Details)Mon, Mar 23, 11:27 PM
This revision was automatically updated to reflect the committed changes.