Update window-pin, Add more sizes, Remove redundant edit-delete
ClosedPublic

Authored by ndavis on Mon, Mar 23, 9:37 PM.

Details

Summary

16 and 22px sizes added for window-pin and unpin. Style was also updated for window-unpin.

edit-delete is redundant because it's already defined in edit.svg. I don't think it's used anywhere at all. It was actually window-close, but renamed to edit-delete for whatever reason.

Test Plan

  1. Install patch to kdesrc-build environment
  2. Run plasmashell --replace & in kdesrc-build environment
  3. Check pin button in systray

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Mon, Mar 23, 9:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Mar 23, 9:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Mon, Mar 23, 9:37 PM
ndavis edited the test plan for this revision. (Show Details)Mon, Mar 23, 9:41 PM
cblack accepted this revision as: VDG, cblack.Mon, Mar 23, 9:45 PM
cblack added a subscriber: cblack.

Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch.

This revision is now accepted and ready to land.Mon, Mar 23, 9:45 PM

Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch.

eh, it's not. I guess I could do it in a separate patch. It's just a pain to untangle multiple changes when the icons are all in the same SVG.

This revision was automatically updated to reflect the committed changes.