make && ctest
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- l-qset-fromlist (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23919 Build 23937: arc lint + arc unit
applets/kicker/plugin/runnermodel.cpp | ||
---|---|---|
179 | Here should be m_runners = runners to be exactly same as previous. I don't see much benefit of having duplicate items. |
applets/kicker/plugin/runnermodel.cpp | ||
---|---|---|
179 | IIUC, the original code used toSet() to remove duplicates from both "m_runners" and "runners", because QSet doesn't allow duplicate items. |
applets/kicker/plugin/runnermodel.cpp | ||
---|---|---|
179 | But toSet() returns new container m_runners and runners are unmodified. |
applets/kicker/plugin/runnermodel.cpp | ||
---|---|---|
179 | I don't mind reverting that bit, but it seems wasteful to me to throw newRunners away, it is sorted and has no duplicates.... |