The deprecated toSet method of the QList class has been refactored as in the deprecation message suggested.
Details
Details
Diff Detail
Diff Detail
- Repository
- R308 KRunner
- Branch
- deprecation_fix (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22816 Build 22834: arc lint + arc unit
Comment Actions
Hi there. Since KF5 min. supported Qt version is 5.12, you have to make the code conditional so that it still build on Qt < 5.14.
(Qt 5.14 is where range-iterators-based constructors were introduced to Qt containers including QList https://doc.qt.io/qt-5/qlist.html#QList-4).
For an example see: https://phabricator.kde.org/R91:202af7d3f3275c998f06fbb8f414f23215e867ef
Comment Actions
Makes sense. It would be ideal to have a way to do an unsorted comparison without having to create 2 temporary sets every time, although I guess it's out of scope here.