Port away from deprecated QSet/QList methods in some places
Needs ReviewPublic
Actions

Authored by ahmadsamir on Mar 19 2020, 8:14 AM.

Details

Reviewers

davidedmundson
apol

Group Reviewers

Plasma

Test Plan

make && ctest

Repository

R120 Plasma Workspace

Branch

l-qset-fromlist (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24144
Build 24162: arc lint + arc unit

ahmadsamir requested review of this revision.Mar 19 2020, 8:14 AM

anthonyfieroni added inline comments.

applets/kicker/plugin/runnermodel.cpp
179	Here should be `m_runners = runners` to be exactly same as previous. I don't see much benefit of having duplicate items.

applets/kicker/plugin/runnermodel.cpp
179	IIUC, the original code used toSet() to remove duplicates from both "m_runners" and "runners", because QSet doesn't allow duplicate items.

applets/kicker/plugin/runnermodel.cpp
179	But toSet() returns new container m_runners and runners are unmodified.

applets/kicker/plugin/runnermodel.cpp
179	I don't mind reverting that bit, but it seems wasteful to me to throw newRunners away, it is sorted and has no duplicates....

QStringList has a sort() method

Ping.

			Path	Packages
M			applets/kicker/plugin/runnermodel.cpp (12 lines)
M			dataengines/systemmonitor/systemmonitor.cpp (4 lines)
M			kcms/translations/translationsmodel.cpp (4 lines)
M			libtaskmanager/launchertasksmodel.cpp (10 lines)
M			libtaskmanager/taskgroupingproxymodel.cpp (12 lines)
M			wallpapers/image/backgroundlistmodel.cpp (5 lines)