Port away from deprecated QSet/QList methods in some places
Needs ReviewPublic

Authored by ahmadsamir on Thu, Mar 19, 8:14 AM.

Details

Reviewers
davidedmundson
apol
Group Reviewers
Plasma
Test Plan

make && ctest

Diff Detail

Repository
R120 Plasma Workspace
Branch
l-qset-fromlist (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24144
Build 24162: arc lint + arc unit
ahmadsamir created this revision.Thu, Mar 19, 8:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Mar 19, 8:14 AM
ahmadsamir requested review of this revision.Thu, Mar 19, 8:14 AM
anthonyfieroni added inline comments.
applets/kicker/plugin/runnermodel.cpp
179

Here should be m_runners = runners to be exactly same as previous. I don't see much benefit of having duplicate items.

ahmadsamir added inline comments.Thu, Mar 19, 11:17 AM
applets/kicker/plugin/runnermodel.cpp
179

IIUC, the original code used toSet() to remove duplicates from both "m_runners" and "runners", because QSet doesn't allow duplicate items.

applets/kicker/plugin/runnermodel.cpp
179

But toSet() returns new container m_runners and runners are unmodified.

ahmadsamir added inline comments.Thu, Mar 19, 11:41 AM
applets/kicker/plugin/runnermodel.cpp
179

I don't mind reverting that bit, but it seems wasteful to me to throw newRunners away, it is sorted and has no duplicates....

ahmadsamir updated this revision to Diff 78355.Tue, Mar 24, 1:59 PM

QStringList has a sort() method