[Various KCMs] Notify about changes in GTK related settings
ClosedPublic
Actions

Authored by gikari on Mar 9 2020, 8:34 PM.

Details

Reviewers

ngraham
ervin
bport
meven

Group Reviewers

Plasma

Commits

R119:eede3025c84b: [Various KCMs] Notify about changes in GTK related settings

Summary

Also save colors before saving colorScheme name, so that we can
correctly use heuristic in GTK Config, after the moment we know, that
color scheme has changed.

Test Plan

Check if the order of saving colors and saving color scheme name does not break anything.

Diff Detail

Repository

R119 Plasma Desktop

Branch

notify-about-changes-in-gtk-related-settings (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23486
Build 23504: arc lint + arc unit

gikari created this revision.Mar 9 2020, 8:34 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 9 2020, 8:34 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gikari requested review of this revision.Mar 9 2020, 8:34 PM

Harbormaster completed remote builds in B23486: Diff 77313.Mar 9 2020, 8:34 PM

gikari mentioned this in D27957: [GTK Config] Port all settings to KConfigWatcher.Mar 9 2020, 8:42 PM

gikari added a dependent revision: D27957: [GTK Config] Port all settings to KConfigWatcher.Mar 9 2020, 8:42 PM

gikari added a reviewer: Plasma.Mar 9 2020, 9:02 PM

davidre awarded a token.Mar 9 2020, 9:11 PM

I'm finding myself wondering why we don't just make everything notify by default.

This revision is now accepted and ready to land.Mar 10 2020, 4:22 PM

gikari added a dependent revision: D28072: [GTK Config] Apply color scheme to GTK3 applications.Mar 16 2020, 1:00 PM

In D27956#625419, @ngraham wrote:

I'm finding myself wondering why we don't just make everything notify by default.

IMHO it's mostly a question of limiting the chatter on the bus.

Closed by commit R119:eede3025c84b: [Various KCMs] Notify about changes in GTK related settings (authored by gikari). · Explain WhyMar 16 2020, 7:35 PM

This revision was automatically updated to reflect the committed changes.

gikari mentioned this in R99:702607595599: [GTK Config] Port all settings to KConfigWatcher.Mar 16 2020, 7:40 PM

gikari removed a dependent revision: D28072: [GTK Config] Apply color scheme to GTK3 applications.Mar 17 2020, 7:15 PM

Revision Contents
Changeset List

			Path	Packages
M			kcms/colors/colors.cpp (5 lines)
M			kcms/colors/colorssettings.kcfgc (1 line)
M			kcms/fonts/fontssettings.kcfgc (1 line)
M			kcms/icons/iconssettingsbase.kcfgc (1 line)
M			kcms/style/stylesettings.kcfgc (1 line)
M			kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc (2 lines)