Differential D27633

Port to KPluginLoader
ClosedPublic
Actions

Authored by nicolasfella on Feb 24 2020, 11:03 PM.

Details

Reviewers
bshah
leinir
apol
Group Reviewers
Frameworks
Commits
R155:27487ab9276c: Port to KPluginLoader
Summary

Make it consistent with our plugin systems elsewehere

Diff Detail

Repository
R155 KAccounts Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Feb 24 2020, 11:03 PM
nicolasfella created this revision.
apol accepted this revision.Feb 24 2020, 11:20 PM
This revision is now accepted and ready to land.Feb 24 2020, 11:20 PM
Closed by commit R155:27487ab9276c: Port to KPluginLoader (authored by nicolasfella). · Explain WhyFeb 24 2020, 11:36 PM
This revision was automatically updated to reflect the committed changes.
leinir added inline comments.Feb 25 2020, 1:24 PM
src/lib/kaccountsdplugin.cpp
24

This caused a compiler warning to show up - pushed a quick fix already so don't worry about it, but thought i'd mention it for completion's sake :) https://commits.kde.org/kaccounts-integration/74e770cc9398d9802f9d0fef652cb5b6da29a74d

lbeltrame added a subscriber: lbeltrame.Feb 27 2020, 12:37 PM

This currently causes a compile error:

/home/abuild/rpmbuild/BUILD/kaccounts-integration-20.03.70git.20200225T132248~74e770c/src/daemon/daemon.cpp:62:78: error: call of overloaded 'create(AccountsDaemon*, <brace-enclosed initializer list>)' is ambiguous
aacid added a subscriber: aacid.Feb 28 2020, 10:02 AM

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

aacid added a comment.Feb 28 2020, 10:49 AM
In D27633#619365, @aacid wrote:

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so revert?

aacid added a comment.Feb 28 2020, 10:51 AM
In D27633#619369, @aacid wrote:
In D27633#619365, @aacid wrote:

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so revert?

kaccount-integrations is not a KF5 repo ^_^

pino added a subscriber: pino.Jun 14 2020, 4:19 AM
In D27633#619369, @aacid wrote:
In D27633#619365, @aacid wrote:

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so revert?

Even if it is not a Framework, this is still a BIC change without an SONAME bump; @nicolasfella what about bumping KACCOUNTS_SOVERSION in the top-level CMakeLists.txt to 2 to reflect that?

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/lib/kaccountsdplugin.cpp (2 lines)

Diff 76335

View Options

src/lib/kaccountsdplugin.cpp

Loading...