- Validate only the files and symlinks
- Fix target names, they were swapped
- generate the icons in build-dir and then install it
Details
done make and make install and verified install_manifest.txt looks sane
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I'd rather have the excess spaces been done away with. Otherwise LGTM, please rebase and land.
icons-dark/CMakeLists.txt | ||
---|---|---|
17 | Any reason for this generated/ subdir? It breaks symlinks, which only do "../../" because they don't expect to have to go out of one-more-subdir (and they don't after installation). Note that symlinktest only checks the source dir (which is another bug), so it doesn't fail locally if you use a builddir completely outside the srcdir. But on CI it seems to be a subdir, so the recursive search in the source dir finds them. |
Nobody cares about broken CI, or my comment here wasn't noticed, so I fixed it myself. https://phabricator.kde.org/D28188