breeze-icons autotests: skip symlinks in the builddir
ClosedPublic

Authored by dfaure on Mar 21 2020, 5:03 PM.

Details

Summary

It's ok for symlinks in the builddir to be broken.
We can't (easily) detect that they actually point to something that will
exist after make install.

With a typical kdesrc-build setup the test passed because it ignored the
builddir (which is outside the srcdir) completely.

In CI however the builddir is a subdir, so the recursive directory
traversal in the unittest ends up there...

Test Plan

bin/symlink works again. I created a broken symlink in the srcdir, it detected it.

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24034
Build 24052: arc lint + arc unit
dfaure created this revision.Mar 21 2020, 5:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 21 2020, 5:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Mar 21 2020, 5:03 PM
sitter accepted this revision.Mar 22 2020, 7:21 PM
This revision is now accepted and ready to land.Mar 22 2020, 7:21 PM
dfaure closed this revision.Mar 22 2020, 7:38 PM