icon sizes and label placements tested correct in several scenarios
- control.icon.width/height is used as maximum size of the icon
- if the button is smaller icons always scale down
- icons stay ccentered regardless of button size when there is no text
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R242:ba0b637de94a: fix layout size hints for button labels
fixes icon sizes without workarounds like D27260
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- phab/buttonslayout
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22660 Build 22678: arc lint + arc unit
| tests/components/button3.qml | ||
|---|---|---|
| 90–125 | this doesn't contain an icon, which is the majority of what this patch is about | |
| tests/components/button3.qml | ||
|---|---|---|
| 90–125 | added | |
| tests/components/button3.qml | ||
|---|---|---|
| 90–125 | You didn't even run this :(
| |
| tests/components/button3.qml | ||
|---|---|---|
| 90–125 | sorry, | |
| src/declarativeimports/plasmacomponents3/Button.qml | ||
|---|---|---|
| 62 | I don't understand this part about constraining the width to the parent height (for all 3) If I remove it all the tests still pass. | |
| src/declarativeimports/plasmacomponents3/Button.qml | ||
|---|---|---|
| 62 | was an extra constraint to have buttons always square, but i added some test and removed this , they seem to behave always well without it | |
Comment Actions
This patch also does not fix the media controller buttons' icon sizes, so D27449 is still needed. :/