icon sizes and label placements tested correct in several scenarios
- control.icon.width/height is used as maximum size of the icon
- if the button is smaller icons always scale down
- icons stay ccentered regardless of button size when there is no text
davidedmundson |
Plasma |
icon sizes and label placements tested correct in several scenarios
fixes icon sizes without workarounds like D27260
No Linters Available |
No Unit Test Coverage |
Buildable 22579 | |
Build 22597: arc lint + arc unit |
tests/components/button3.qml | ||
---|---|---|
90 ↗ | (On Diff #75922) | this doesn't contain an icon, which is the majority of what this patch is about |
tests/components/button3.qml | ||
---|---|---|
90 ↗ | (On Diff #75922) | added |
tests/components/button3.qml | ||
---|---|---|
90 ↗ | (On Diff #75922) | You didn't even run this :(
|
tests/components/button3.qml | ||
---|---|---|
90 ↗ | (On Diff #75922) | sorry, |
src/declarativeimports/plasmacomponents3/Button.qml | ||
---|---|---|
59 | I don't understand this part about constraining the width to the parent height (for all 3) If I remove it all the tests still pass. |
src/declarativeimports/plasmacomponents3/Button.qml | ||
---|---|---|
59 | was an extra constraint to have buttons always square, but i added some test and removed this , they seem to behave always well without it |
This patch also does not fix the media controller buttons' icon sizes, so D27449 is still needed. :/