[applets/mediacontroller] Fix Playback button icon sizes

Authored by ngraham on Feb 17 2020, 1:06 AM.


Group Reviewers

Same as D27260. Following D27396, we need to fix cases where PC3 ToolButtons were
previously relying on implicit behavior and the icon size should not be set explicitly.

Test Plan


With this patch:

(Ignore other visual changes in the before-and-after images, and the broken Pin button icon is fixed by D27260)

Diff Detail

R120 Plasma Workspace
fix-mediaplayer-button-size (branched from Plasma/5.18)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 22558
Build 22576: arc lint + arc unit
ngraham created this revision.Feb 17 2020, 1:06 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2020, 1:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 17 2020, 1:06 AM
ngraham edited the test plan for this revision. (Show Details)Feb 17 2020, 1:07 AM

So it appears this is a regression in Frameworks which needs fixing all over the place

mart added a subscriber: mart.Feb 24 2020, 9:04 AM

so: the latest, long discussed buttons revision is to have button icons that can scale automatically downand up to the "small" (and smallmedium for toolbuttons) size, as this is the behavior of qwidget buttons, and the goal at some point was to make the controls in plasma to be more sonsistent with the desktop ones.

I may try to modify it further and permit upper scaling as well, preeetty sure even that will have unintended consequences but we'll see.