The match method has been rewritten and the profiles are only loaded when the plugin
is initialized or the config folder changes.
Details
Details
- Reviewers
davidedmundson ngraham tcanabrava hindenburg broulik meven - Group Reviewers
Plasma Konsole - Commits
- R114:50c93e3c94e2: Konsole Runner: optimize and simplify
Create different profiles and start the runner using the keyword "konsole", all profiles should show
up, if one is selected, konsole launches with this profile.
To filter the profiles you can type "konsole KEYWORD" and only the profiles that contain the keyword show up.
Furthermore you can create/edit/delete new profiles after the runner is initailized and they still show up.
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- arcpatch-D27098_1
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24896 Build 24914: arc lint + arc unit
Comment Actions
If you ask me, this patch does many things:
- fixes an issue
- changes coding style
- does some code bits a bit more differently.
It's hard to review for me, I hope someone else more familiar with the codebase can.
runners/konsoleprofiles/konsoleprofiles.cpp | ||
---|---|---|
155 | Why has the relevance code been removed? |
runners/konsoleprofiles/konsoleprofiles.cpp | ||
---|---|---|
155 | It has been refactored and is now in line 132/188: |
runners/konsoleprofiles/konsoleprofiles.cpp | ||
---|---|---|
155 | Ups, 118 not 188 |
This comment was removed by alex.