Don't use KWindowSystem on Android
ClosedPublic
Actions

Authored by nicolasfella on Jan 8 2020, 8:14 PM.

Details

Reviewers

vkrause
apol
dfaure

Group Reviewers

Frameworks

Commits

R289:33742dde2f73: Don't use KWindowSystem on Android

Summary

The usage of KWindowSystem is not relevant on Android. This saves us a dependency there.

Ideally we wouldn't build KPassivePopup at all there, but unfortunately it is public API. One could argue that such a break for non-functional API on Android could be okay.

Depends on D26513

Test Plan

Builds on Android and Linux

Diff Detail

Repository

R289 KNotifications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Jan 8 2020, 8:14 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 8 2020, 8:14 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jan 8 2020, 8:14 PM

Harbormaster completed remote builds in B20825: Diff 73095.Jan 8 2020, 8:14 PM

nicolasfella edited the summary of this revision. (Show Details)Jan 8 2020, 8:17 PM

nicolasfella added a dependency: D26513: Port KNotification from KWindowSystem.

We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an empty stub is a useful porting aid.

This revision is now accepted and ready to land.Jan 8 2020, 8:33 PM

In D26532#590598, @vkrause wrote:

We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an empty stub is a useful porting aid.

IIRC the case with KSNI on Android was a bit different since it never was part of the ABI on Android, whereas KPassivePopup is.

In D26532#590609, @nicolasfella wrote:

In D26532#590598, @vkrause wrote:

We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an empty stub is a useful porting aid.

IIRC the case with KSNI on Android was a bit different since it never was part of the ABI on Android, whereas KPassivePopup is.

True. But do the same ABI rules even apply to Android, given there is no way to distribute libraries shared between multiple consumers there, and given the early stages of supporting Android in KF5?

Pragmatically speaking I want to say 'No'.

@dfaure Do you have an opinion on this?

apol accepted this revision.Jan 9 2020, 1:17 AM

I agree with the reasoning, we can break BC on Android.

Closed by commit R289:33742dde2f73: Don't use KWindowSystem on Android (authored by nicolasfella). · Explain WhyJan 12 2020, 4:13 PM

This revision was automatically updated to reflect the committed changes.