Port KNotification from KWindowSystem
ClosedPublic
Actions

Authored by davidedmundson on Jan 8 2020, 1:18 AM.

Details

Reviewers

nicolasfella

Maniphest Tasks

Commits

R289:32c84f532f66: Port KNotification from KWindowSystem

Summary

KWindowSystem::activateWindow does the same system call as
QWindow::requestActivate for X11 and Windows and both currently do
nothing on wayland.

May as well use Qt implementation

Repository

R289 KNotifications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jan 8 2020, 1:18 AM

This revision is now accepted and ready to land.Jan 8 2020, 1:25 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/knotification.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73027	84113c3		Jan 8 2020, 1:18 AM	★	★
Diff 2	73107	8c3bbf9	R289:32c84f532f66731a883983ff33957a75b0cd32f3	Jan 8 2020, 10:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7d41b8bf1c81	57491fecadda	84113c3af6b6	David Edmundson	Port KNotification from KWindowSystem (Show More…)	Jan 8 2020, 1:18 AM

	Status	Author	Revision
	Closed	nicolasfella	D26532 Don't use KWindowSystem on Android
	Closed	davidedmundson	D26513 Port KNotification from KWindowSystem