KIO/SMB convert kio protocol declaration to json format
ClosedPublic

Authored by meven on Jan 2 2020, 7:21 AM.

Diff Detail

Repository
R320 KIO Extras
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20525
Build 20543: arc lint + arc unit
meven created this revision.Jan 2 2020, 7:21 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptJan 2 2020, 7:21 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 2 2020, 7:21 AM
apol added a subscriber: apol.Jan 2 2020, 12:23 PM
apol added inline comments.
smb/kio_smb.cpp
42

Shouldn't this go in the SMBSlave class?

meven marked an inline comment as done.Jan 4 2020, 12:41 PM
meven added inline comments.
smb/kio_smb.cpp
42

No this is fine, this is done the same way in trash, file, recentlyused io~slaves...
Follows https://github.com/shortstheory/kioslave-tutorial

pino added a subscriber: pino.Jan 4 2020, 12:52 PM
pino added inline comments.
smb/smb.json
27

erm...

smb/smb.protocol
11 ↗(On Diff #72596)

what about this key?

meven edited the summary of this revision. (Show Details)Jan 4 2020, 12:54 PM
meven updated this revision to Diff 72742.Jan 4 2020, 12:55 PM
meven marked 4 inline comments as done.

Fix json

meven added a comment.Jan 4 2020, 12:56 PM

I have tested it and it solves https://bugs.kde.org/show_bug.cgi?id=414482
It seems .protocol file support has some issue.

meven edited the summary of this revision. (Show Details)Jan 4 2020, 12:56 PM
meven updated this revision to Diff 72743.Jan 4 2020, 12:56 PM

Update commit message

pino removed a subscriber: pino.Jan 4 2020, 12:57 PM
meven edited the summary of this revision. (Show Details)Jan 4 2020, 2:04 PM
meven added a comment.Jan 4 2020, 4:10 PM

BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :(

I mistested this, and removed the "BUG: 414482" accordingly.

I don't reproduce this bug locally unfortunately myself. I would have been happy to fix it.

ngraham accepted this revision.Jan 6 2020, 3:23 PM

Well, at least it doesn't hurt anything and it's more technically correct. :)

This revision is now accepted and ready to land.Jan 6 2020, 3:23 PM
This revision was automatically updated to reflect the committed changes.