Details

Reviewers

ngraham

Group Reviewers

Frameworks

Commits

R320:0354fd11f1f0: KIO/SMB convert kio protocol declaration to json format

Diff Detail

Repository

R320 KIO Extras

Branch

arcpatch-D26358

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20616
Build 20634: arc lint + arc unit

meven created this revision.Jan 2 2020, 7:21 AM

Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptJan 2 2020, 7:21 AM

Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Jan 2 2020, 7:21 AM

Harbormaster completed remote builds in B20524: Diff 72595.Jan 2 2020, 7:21 AM

clean

Harbormaster completed remote builds in B20525: Diff 72596.Jan 2 2020, 7:22 AM

Not too sure if it helps bug https://bugs.kde.org/show_bug.cgi?id=414482

apol added a subscriber: apol.Jan 2 2020, 12:23 PM

apol added inline comments.

smb/kio_smb.cpp
42	Shouldn't this go in the SMBSlave class?

meven marked an inline comment as done.Jan 4 2020, 12:41 PM

meven added inline comments.

smb/kio_smb.cpp
42	No this is fine, this is done the same way in trash, file, recentlyused io~slaves... Follows https://github.com/shortstheory/kioslave-tutorial

pino added a subscriber: pino.Jan 4 2020, 12:52 PM

pino added inline comments.

smb/smb.json
28	erm...
smb/smb.protocol
11	what about this key?

meven edited the summary of this revision. (Show Details)Jan 4 2020, 12:54 PM

Fix json

Harbormaster completed remote builds in B20615: Diff 72742.Jan 4 2020, 12:55 PM

I have tested it and it solves https://bugs.kde.org/show_bug.cgi?id=414482
It seems .protocol file support has some issue.

meven edited the summary of this revision. (Show Details)Jan 4 2020, 12:56 PM

Update commit message

Harbormaster completed remote builds in B20616: Diff 72743.Jan 4 2020, 12:56 PM

pino removed a subscriber: pino.Jan 4 2020, 12:57 PM

meven edited the summary of this revision. (Show Details)Jan 4 2020, 2:04 PM

BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :(

In D26358#587596, @ngraham wrote:

BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :(

I mistested this, and removed the "BUG: 414482" accordingly.

I don't reproduce this bug locally unfortunately myself. I would have been happy to fix it.

Well, at least it doesn't hurt anything and it's more technically correct. :)

This revision is now accepted and ready to land.Jan 6 2020, 3:23 PM

Closed by commit R320:0354fd11f1f0: KIO/SMB convert kio protocol declaration to json format (authored by meven). · Explain WhyJan 6 2020, 3:44 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		smb/CMakeLists.txt (1 line)
M		smb/kio_smb.cpp (8 lines)
A	M	smb/smb.json (33 lines)
D	M	smb/smb.protocol (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72595	55d3703		Jan 2 2020, 7:21 AM	★	★
Diff 2	72596	55d3703	clean	Jan 2 2020, 7:22 AM	★	★
Diff 3	72742	55d3703	Fix json	Jan 4 2020, 12:55 PM	★	★
Diff 4	72743	55d3703	Update commit message	Jan 4 2020, 12:56 PM	★	★
Diff 5	72900	a4f3a58	R320:0354fd11f1f079ce7de639c5b4092924f6ed6cbd	Jan 6 2020, 3:43 PM	★	★

KIO/SMB convert kio protocol declaration to json format
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 72743

smb/CMakeLists.txt

smb/kio_smb.cpp

smb/smb.json

smb/smb.protocol

KIO/SMB convert kio protocol declaration to json formatClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 72743

smb/CMakeLists.txt

smb/kio_smb.cpp

smb/smb.json

smb/smb.protocol

KIO/SMB convert kio protocol declaration to json format
ClosedPublic
Actions

Revision Contents
Changeset List