Differential D26101

Port away from Qt 5.14 deprecated QList methods
ClosedPublic
Actions

Authored by ahmadsamir on Dec 19 2019, 11:54 AM.

Details

Reviewers
meven
bruns
astippich
dfaure
Group Reviewers
Baloo
Maniphest Tasks
T11553: Port KDE Frameworks away from deprecated methods in Qt
Commits
R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList methods
Summary

Refactor FileIndexerConfig::excludeFilters() as it doesn't make sense
to me to convert to a QStringList to a QSet then to QStringList, if
there is a reason I couldn't fathom it.

Test Plan

The code compiles and unit tests pass

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 19 2019, 11:54 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 19 2019, 11:54 AM
ahmadsamir requested review of this revision.Dec 19 2019, 11:54 AM
ahmadsamir updated this revision to Diff 71835.Dec 19 2019, 12:05 PM
ahmadsamir retitled this revision from Port away from Qt 14.0 deprecated QList methods to Port away from Qt 5.14 deprecated QList methods.

Qt 14 hasn't been released yet (I kept thinking something looks wrong...)

alexeymin added a subscriber: alexeymin.Dec 19 2019, 12:24 PM

Partially looks similar to what I did in D26069 , although that's not framework

dfaure accepted this revision.Dec 20 2019, 9:18 AM
This revision is now accepted and ready to land.Dec 20 2019, 9:18 AM
Closed by commit R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList methods (authored by ahmadsamir). · Explain WhyDec 20 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.
ahmadsamir added a comment.Jan 21 2020, 7:34 PM

FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and toSet(), made me understand why the original code was using toSet(), then fromSet(), it was to remove duplicates as QSet doesn't allow duplicates.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 71885