Refactor FileIndexerConfig::excludeFilters() as it doesn't make sense
to me to convert to a QStringList to a QSet then to QStringList, if
there is a reason I couldn't fathom it.
Details
Details
- Reviewers
meven bruns astippich dfaure - Group Reviewers
Baloo - Maniphest Tasks
- T11553: Port KDE Frameworks away from deprecated methods in Qt
- Commits
- R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList methods
The code compiles and unit tests pass
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Branch
- l-qt14-deprecated (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20048 Build 20066: arc lint + arc unit
Comment Actions
FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and toSet(), made me understand why the original code was using toSet(), then fromSet(), it was to remove duplicates as QSet doesn't allow duplicates.