Detangle the code, implement models and start the Qml
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- kcm_formats
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19037 Build 19055: arc lint + arc unit
| kcms/formats/Messages.sh | ||
|---|---|---|
| 2 | this should say qml somewhere? | |
| kcms/formats/README | ||
| 1 | not relevant | |
| kcms/formats/formatssettings.kcfg | ||
| 2 | ooh, nice | |
| kcms/formats/localemodel.cpp | ||
| 15 | c1 == QLocale::c() might be better than comparing names? | |
| kcms/formats/localemodel.h | ||
| 29 | this is duplicating data() no? | |
| kcms/formats/package/contents/ui/main.qml | ||
| 117 | there's another signal should be used onActivated or sth that only includes user updates | |
| kcms/formats/package/metadata.desktop | ||
| 3 | -> | |
| 12–15 | All of these 3 lines are wrong | |