Start of the new Formats KCM
Needs ReviewPublic

Authored by tcanabrava on Thu, Nov 21, 8:24 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Detangle the code, implement models and start the Qml

Diff Detail

Repository
R119 Plasma Desktop
Branch
kcm_formats
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19037
Build 19055: arc lint + arc unit
tcanabrava created this revision.Thu, Nov 21, 8:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Nov 21, 8:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tcanabrava requested review of this revision.Thu, Nov 21, 8:24 PM
davidedmundson added inline comments.
kcms/formats/Messages.sh
2

this should say qml somewhere?

kcms/formats/README
1

not relevant

kcms/formats/formatssettings.kcfg
2

ooh, nice

kcms/formats/localemodel.cpp
15

c1 == QLocale::c()

might be better than comparing names?

kcms/formats/localemodel.h
29

this is duplicating data() no?

kcms/formats/package/contents/ui/main.qml
117

there's another signal should be used

onActivated or sth that only includes user updates

kcms/formats/package/metadata.desktop
3

->

12–15

All of these 3 lines are wrong