WIP, I want feedback from VDG or whomever
Details
Details
Diff Detail
Diff Detail
- Repository
- R985 KDE Human Interface Guidelines
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20723 Build 20741: arc lint + arc unit
Comment Actions
I agree that animations should be consistent and specified in the HIG. I will see if there's anything I can do to help you with this page.
Regarding the easing curve; I tried to see Cubic and Quad may times, and it seems to me that Cubic feels more natural and responsive to me. Personally, I would suggest to use that easing curve.
Comment Actions
Change the page title and filename from "Animations" to "Animation"
In terms of Quad vs Cubic, I think it would make the most sense to use this page to describe the current state of reality (so, Quad). Then, we should define the default easing curves for visible->invisible, invisible->visible, and visible->visible in some central location, and port everything to pull the data from there rather than hardcoding it. Finally, we should discuss what those standardized easing curves should be. I also slightly prefer Cubic to Quad, having used it now, but we should consistently use the same one everywhere.
Does that sound like a sane and doable plan?
| HIG/source/style/animations.rst | ||
|---|---|---|
| 3 | Not enough equals signs | |
| 6 | Too many dashes. Also, do we really need this section at all if it's going to be empty? Maybe just delete it. | |
| 9 | Too many tildes | |
| 11 | Animations can -> Animation can (otherwise there's a singular vs plural mismatch in the sentence) | |
| 12 | glaring sudden -> sudden glaring | |
| 14 | for eye candy -> as eye candy or for visual flair | |
| 18 | One tilde too many | |
Comment Actions
Personally, I would suggest to use that easing curve.
That comes under the pixel pushing details that I am happy to delegate to the VDG.
My job is just to ensure things are consistent.
Plan makes sense.
I want something about duration in here, when to use short, long or custom, but we can build that in later.
| HIG/source/style/animations.rst | ||
|---|---|---|
| 3 | Do you have a link to the syntax? I just copy/pasted and then rendered. | |
| HIG/source/style/animations.rst | ||
|---|---|---|
| 3 | Not really, I'm a Sphinx n00b. I just remember that it complains during compilation when the chars aren't as long as the text above them. | |
Comment Actions
As mentioned in D18000 I think the following two things should be adjusted. I think it is more natural that way.
Material Design does this, MS Fluent does this, Apple's Design Language does this. I don't think it would make sense if we would do this differently.
| HIG/source/style/animations.rst | ||
|---|---|---|
| 22 | This should be InQuad. Meaning the animation starts slow, accelerates and eventually becomes linear. | |
| 23 | This should be OutQuad, as it should start linear and then decelerate. | |
Comment Actions
Having played with it a bit, I agree with @sefaeyeoglu here. Reversing them from what's currently proposed feels nicer to me. Things enter faster, which is ultimately what you want for things that animate from invisible to visible.
Comment Actions
Ok, will update.
When something comes in we use outquad, when something goes out we use inquad.
Not confusing at all :)
FWIW, I found the syntax:
If under and overline are used, their length must be identical The length of the underline must be at least as long as the title itself
Comment Actions
Apparently I am not that important :(
FATAL: W any websites/hig-kde-org davidedmundson DENIED by fallthru
boo!
Comment Actions
I've landed this for you in https://cgit.kde.org/websites/hig-kde-org.git/commit/?id=ad3d052e47f0d24f0548bd14cff2749345ea5968
For future reference, HIG patches are generally submitted using GitLab now: https://invent.kde.org/websites/hig-kde-org/
Comment Actions
Please, push a commit to fix the headers. See https://binary-factory.kde.org/job/Website_hig-kde-org/157/console
It is just a matter of having the symbools under headers match header text in length.