Differential D25338

Changed sliding popup easing curve to In and Out cubic
ClosedPublic
Actions

Authored by niccolove on Nov 16 2019, 4:59 PM.

Details

Reviewers
ngraham
Group Reviewers
KWin
VDG
Summary

Change the easing curve to cubic to make the sliding popup feel more responsive without changing the animation time.

Diff Detail

Repository
R108 KWin
Branch
cubic_easing_curve_sliding_popup (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 18881
Build 18899: arc lint + arc unit
niccolove created this revision.Nov 16 2019, 4:59 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 16 2019, 4:59 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
niccolove requested review of this revision.Nov 16 2019, 4:59 PM
ngraham accepted this revision.Nov 16 2019, 5:25 PM
ngraham added a subscriber: ngraham.

I gave this a try yesterday when it was first brought up in the VDG room and have been using it since then. I quite like it. It makes popups open and close a bit faster, and the effect is subtle and tasteful IMO.

KWin folks, are you okay with this change?

This revision is now accepted and ready to land.Nov 16 2019, 5:25 PM
davidedmundson added a subscriber: davidedmundson.Nov 16 2019, 6:50 PM

I agree on the In/Out changes
Cubic seems random. I grepped plasma, 95% is quad.

Lets try and get some policy defined so we're not just replacing one random thing with another random thing
https://phabricator.kde.org/D25343

niccolove updated this revision to Diff 69883.Nov 17 2019, 5:23 PM

Changed sliding popup easing curve to In and Out cubic

niccolove added a comment.Nov 17 2019, 5:24 PM

While D25343 is being discussed, we can change the effect to Quad from Sine so it's already more consistent, eventually change to cubic if there's agreement on that in the future.

ngraham added a comment.Nov 17 2019, 6:45 PM
In D25338#563745, @niccolove wrote:

While D25343 is being discussed, we can change the effect to Quad from Sine so it's already more consistent, eventually change to cubic if there's agreement on that in the future.

+1, that makes this an uncontroversial bugfix, even.

filipf added a subscriber: filipf.EditedNov 17 2019, 8:59 PM

There is already a patch trying to change this, it would be good to involve Sefa as well: D18000

ngraham added a comment.Nov 18 2019, 4:34 PM

yeah, let's do this in D18000.

ngraham closed this revision.Dec 5 2019, 9:04 PM

Revision Contents
Changeset List

Diff 69883

View Options

effects/slidingpopups/slidingpopups.cpp

Loading...