sefaeyeoglu (Sefa Eyeoglu)
Spy

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2017, 6:04 PM (110 w, 14 h)
Availability
Available

Recent Activity

Sun, Oct 13

baberts awarded D13243: Add checkbox that can show virtual streams in the applet. a Love token.
Sun, Oct 13, 3:24 AM · Plasma

Sat, Oct 12

sefaeyeoglu added a comment to D13243: Add checkbox that can show virtual streams in the applet..

Ping!

Sat, Oct 12, 7:22 PM · Plasma

Thu, Oct 10

sefaeyeoglu accepted D24407: Increase UI commonality between KCM and applet.

I had a feeling. I say let's land this, then fix that. Do you agree?

Thu, Oct 10, 2:38 PM · Plasma
sefaeyeoglu added a comment to D24407: Increase UI commonality between KCM and applet.

That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

Sorry that I didn't really make it obvious what I was referring to. For some reason I can check multiple PA sources as default. Sinks on the other hand behave as they should and change their checked state.

P.S. I am master of all repos right now (using kdesrc-build)

How strange. Is that a pre-existing problem, or was it introduced by this patch?

Thu, Oct 10, 2:35 PM · Plasma
sefaeyeoglu added a comment to D24407: Increase UI commonality between KCM and applet.

That should be fixed by D24402, in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

Thu, Oct 10, 2:33 PM · Plasma
sefaeyeoglu added a comment to D24407: Increase UI commonality between KCM and applet.

Nice work! It looks very good now.

Thu, Oct 10, 2:21 PM · Plasma
sefaeyeoglu added a comment to D24407: Increase UI commonality between KCM and applet.


Looks like replacing the label with a combobox breaks alignment in the KCM and exceeds the full width in the applet.

Thu, Oct 10, 2:06 PM · Plasma

Sat, Sep 28

sefaeyeoglu updated the test plan for D24289: Fix wrong KCM device icon for specific form factors.
Sat, Sep 28, 7:20 PM · Plasma
sefaeyeoglu added a comment to D24161: Make KCM look more like applet.

Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port devices, show the port chooser combobox instead of the name of the current port, in both the KCM and the applet. There's guaranteed to be enough room (we'd be replacing a string with the same string in a combobox). Then remove the "Ports" items in the applet's hamburger menu.

Oh and I just noticed a regression I didn't see before landing the patch, sorry. :/ The icons no longer match between the KCM and the applet when I add an external bluetooth device:

Sat, Sep 28, 7:17 PM · VDG, Plasma
sefaeyeoglu requested review of D24289: Fix wrong KCM device icon for specific form factors.
Sat, Sep 28, 7:17 PM · Plasma
sefaeyeoglu added a comment to D24161: Make KCM look more like applet.

Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port devices, show the port chooser combobox instead of the name of the current port, in both the KCM and the applet. There's guaranteed to be enough room (we'd be replacing a string with the same string in a combobox). Then remove the "Ports" items in the applet's hamburger menu.

Oh and I just noticed a regression I didn't see before landing the patch, sorry. :/ The icons no longer match between the KCM and the applet when I add an external bluetooth device:

Sat, Sep 28, 10:49 AM · VDG, Plasma

Fri, Sep 27

sefaeyeoglu updated the summary of D24161: Make KCM look more like applet.
Fri, Sep 27, 6:14 PM · VDG, Plasma
sefaeyeoglu updated the diff for D13243: Add checkbox that can show virtual streams in the applet..

Change behaviour of configuration.

Fri, Sep 27, 2:37 PM · Plasma
sefaeyeoglu added a comment to D13243: Add checkbox that can show virtual streams in the applet..

I think Nate's idea on how to display this in the applet config is better. Will do that instead

Fri, Sep 27, 2:35 PM · Plasma
sefaeyeoglu updated the diff for D13243: Add checkbox that can show virtual streams in the applet..

Put checkbox into own category

Fri, Sep 27, 2:27 PM · Plasma
sefaeyeoglu updated the test plan for D24161: Make KCM look more like applet.
Fri, Sep 27, 12:55 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Align mute button centered with slider

Fri, Sep 27, 12:54 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Fix wrong display name of default-device button

Fri, Sep 27, 12:40 PM · VDG, Plasma

Thu, Sep 26

sefaeyeoglu added a comment to D13243: Add checkbox that can show virtual streams in the applet..

What's the use case?

Thu, Sep 26, 10:08 PM · Plasma
sefaeyeoglu added a comment to D24161: Make KCM look more like applet.

I love it, and the code changes look sane to me.

Plasma folks or @drosca, any objections?

Thu, Sep 26, 8:32 PM · VDG, Plasma
sefaeyeoglu updated the diff for D13243: Add checkbox that can show virtual streams in the applet..

Add copyright header

Thu, Sep 26, 8:28 PM · Plasma
sefaeyeoglu updated the diff for D13243: Add checkbox that can show virtual streams in the applet..

Rebase onto master

Thu, Sep 26, 8:25 PM · Plasma
sefaeyeoglu added a comment to D13243: Add checkbox that can show virtual streams in the applet..

Yikes, looks like this never went anywhere. :/

Can you rebase it?

Thu, Sep 26, 8:14 PM · Plasma
sefaeyeoglu updated the test plan for D24161: Make KCM look more like applet.
Thu, Sep 26, 7:31 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Make icon full height for playback devices, too

Thu, Sep 26, 7:30 PM · VDG, Plasma
sefaeyeoglu added a comment to D24161: Make KCM look more like applet.

Right! I completely forgot about that. Will work on it

Thu, Sep 26, 7:19 PM · VDG, Plasma
sefaeyeoglu updated the test plan for D24161: Make KCM look more like applet.
Thu, Sep 26, 7:10 PM · VDG, Plasma
sefaeyeoglu added inline comments to D24161: Make KCM look more like applet.
Thu, Sep 26, 7:08 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Remove stepping again, change label text of port selection

Thu, Sep 26, 7:07 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Remove redundant whitespace from copyright header

Thu, Sep 26, 5:56 PM · VDG, Plasma
sefaeyeoglu updated the test plan for D24161: Make KCM look more like applet.
Thu, Sep 26, 5:53 PM · VDG, Plasma
sefaeyeoglu updated the test plan for D24161: Make KCM look more like applet.
Thu, Sep 26, 5:52 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Use QQC2 ToolButton instead of Button for Mute. Add stepping to volume slider, similar to applet.

Thu, Sep 26, 5:50 PM · VDG, Plasma

Tue, Sep 24

sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Import QtQuick.Controls as QQC2 and fix ToolTip delay

Tue, Sep 24, 6:49 PM · VDG, Plasma
sefaeyeoglu added inline comments to D24161: Make KCM look more like applet.
Tue, Sep 24, 6:18 PM · VDG, Plasma

Mon, Sep 23

sefaeyeoglu added inline comments to D24161: Make KCM look more like applet.
Mon, Sep 23, 3:42 PM · VDG, Plasma
sefaeyeoglu updated the diff for D24161: Make KCM look more like applet.

Set domain for all i18n strings

Mon, Sep 23, 3:40 PM · VDG, Plasma
sefaeyeoglu added a comment to D24161: Make KCM look more like applet.
In D24161#536408, @GB_2 wrote:

Please add reviewers and subscribers next time.

Mon, Sep 23, 3:34 PM · VDG, Plasma
sefaeyeoglu updated the test plan for D24161: Make KCM look more like applet.
Mon, Sep 23, 3:32 PM · VDG, Plasma
sefaeyeoglu requested review of D24161: Make KCM look more like applet.
Mon, Sep 23, 3:28 PM · VDG, Plasma

Sun, Sep 15

sefaeyeoglu added a comment to T11667: Analyze and evauate easing curves for animations.

We should definitely define how the easing curves should look. Generally I think we should always use some kind of decelerating, but not accelerating, easing for appear animations and accelerating, but not decelerating, for disappear animations. We could look at Material design and specifically on how they are doing easing: https://material.io/design/motion/speed.html#easing.

Sun, Sep 15, 10:38 PM · VDG
sefaeyeoglu triaged T11667: Analyze and evauate easing curves for animations as Normal priority.
Sun, Sep 15, 10:25 PM · VDG
sefaeyeoglu updated the diff for D18000: Tweak slidingpopups effect to make animation smoother.

Fix wrong opacity condition for vertical popups

Sun, Sep 15, 10:00 PM · KWin
sefaeyeoglu updated the summary of D18000: Tweak slidingpopups effect to make animation smoother.
Sun, Sep 15, 9:57 PM · KWin
sefaeyeoglu updated the diff for D18000: Tweak slidingpopups effect to make animation smoother.

Fix syntax error

Sun, Sep 15, 9:54 PM · KWin
sefaeyeoglu updated the diff for D18000: Tweak slidingpopups effect to make animation smoother.

Tidy up code

Sun, Sep 15, 9:50 PM · KWin
sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

I recently set up a proper working environment again and started tinkering with different easings and slide-lengths. I decided to make a compromise between the old animation and the one I proposed before.

Sun, Sep 15, 3:53 PM · KWin
sefaeyeoglu updated the diff for D18000: Tweak slidingpopups effect to make animation smoother.

Compomise between old behaviour and my proposal. Now uses fixed slideLength again, but with different easing.

Sun, Sep 15, 3:51 PM · KWin

Feb 16 2019

sefaeyeoglu added a comment to T10201: Window titlebars.

There are probably people, who would still prefer different titlebar colors from the rest of the window. Therefore I'd add a "Breeze Dark Classic" color scheme to @filipf's proposal, that uses the same titlebar color as "Breeze Classic".
Also why are there different text colors between current Breeze Classic and current Breeze Light?

Feb 16 2019, 12:28 PM · KDE Applications, VDG

Jan 14 2019

sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

I can only speak from experience. I don't know if there are any scientific studies that look at user experience with a focus of animation.

Jan 14 2019, 7:38 PM · KWin

Jan 8 2019

sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

I don't really think that it looks that different than other animations. If one gets used to it it isn't that strange anymore.

Jan 8 2019, 7:09 PM · KWin

Jan 6 2019

sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

Do you have a before and after gif or video?

Jan 6 2019, 6:13 PM · KWin
sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.
In D18000#387618, @zzag wrote:

I tested this patch. In general, it doesn't feel consistent with other animations. I suggest to open a new task regarding easing curves before actually changing them.

Jan 6 2019, 5:14 PM · KWin
sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

Do you have a before and after gif or video?

Jan 6 2019, 4:41 PM · KWin
sefaeyeoglu updated the summary of D18000: Tweak slidingpopups effect to make animation smoother.
Jan 6 2019, 4:33 PM · KWin
sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

I just added the if statement back (but keeping the interpolate). It actually looks better now!

Jan 6 2019, 3:47 PM · KWin
sefaeyeoglu updated the diff for D18000: Tweak slidingpopups effect to make animation smoother.

Change opacity for custom slideLengths only

Jan 6 2019, 3:45 PM · KWin
sefaeyeoglu removed a watcher for VDG: sefaeyeoglu.
Jan 6 2019, 11:00 AM

Jan 5 2019

sefaeyeoglu added a watcher for VDG: sefaeyeoglu.
Jan 5 2019, 11:53 PM
sefaeyeoglu updated the diff for D18000: Tweak slidingpopups effect to make animation smoother.

Restore support for custom slideLength

Jan 5 2019, 11:48 PM · KWin
sefaeyeoglu added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

I personally feel, that timing functions for things appearing should not accelerate, but rather only decelerate.
I am often designing things with influences from different design guidelines, but when it comes to animation I often look at the Material Design Guidelines, as I think that Material Design animations feel natural. They have a section about things appearing and disappearing here. Therefore I chose decelerating/accelerating timing functions.

Jan 5 2019, 11:23 PM · KWin
sefaeyeoglu requested review of D18000: Tweak slidingpopups effect to make animation smoother.
Jan 5 2019, 10:27 PM · KWin

Dec 26 2018

sefaeyeoglu added a comment to T9975: System volume control for Linux.

I thought this is about controlling the system volume and not the media player volume :/

Dec 26 2018, 2:39 PM · KDE Connect
sefaeyeoglu added a comment to T8992: Improve Media Player in app.

Is this still relevant? As far as I can tell album art and position is not supported with all MPRIS media players.

Dec 26 2018, 12:00 PM · KDE Connect
sefaeyeoglu triaged T10226: Two Factor Authenticator - OTP Generation as Wishlist priority.
Dec 26 2018, 11:56 AM · KDE Connect

Nov 25 2018

sefaeyeoglu added a comment to D17048: Restore sendfile support.

Can someone benchmark this? Would be nice to know how much this affects performance.

Nov 25 2018, 3:42 PM · Frameworks

Sep 27 2018

sefaeyeoglu added a comment to T8288: Drag n Drop Filetransfer on the plasmoid.

I tried to implement this feature, but I can't seem to get the DropArea working. Could it be possible that PlasmoidViewer does not support drag 'n' drop? It always appears as an icon inside the PlasmoidViewer similar to FolderView on the normal desktop.

Sep 27 2018, 11:38 AM · Junior Jobs, KDE Connect

May 31 2018

sefaeyeoglu requested review of D13243: Add checkbox that can show virtual streams in the applet..
May 31 2018, 6:18 PM · Plasma