Prepare KConfigSkeletonItem to allow inheriting its private class
ClosedPublic

Authored by ervin on Fri, Nov 8, 11:53 AM.

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Fri, Nov 8, 11:53 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Nov 8, 11:53 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ervin requested review of this revision.Fri, Nov 8, 11:53 AM
vkrause added a subscriber: vkrause.Fri, Nov 8, 1:07 PM

Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class?

ervin updated this revision to Diff 69440.Fri, Nov 8, 1:25 PM

Add missing virtual dtor

ervin added a comment.Fri, Nov 8, 1:25 PM

Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class?

You mean like not leaking memory? woops. ;-)

vkrause accepted this revision.Fri, Nov 8, 1:29 PM
This revision is now accepted and ready to land.Fri, Nov 8, 1:29 PM
This revision was automatically updated to reflect the committed changes.