Differential D25210

Prepare KConfigSkeletonItem to allow inheriting its private class
ClosedPublic
Actions

Authored by ervin on Nov 8 2019, 11:53 AM.

Details

Reviewers
dfaure
davidedmundson
bport
crossi
vkrause
Group Reviewers
Frameworks
Commits
R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow inheriting its private class

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Nov 8 2019, 11:53 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 8 2019, 11:53 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ervin requested review of this revision.Nov 8 2019, 11:53 AM
vkrause added a subscriber: vkrause.Nov 8 2019, 1:07 PM

Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class?

ervin updated this revision to Diff 69440.Nov 8 2019, 1:25 PM

Add missing virtual dtor

ervin added a comment.Nov 8 2019, 1:25 PM
In D25210#559977, @vkrause wrote:

Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class?

You mean like not leaking memory? woops. ;-)

vkrause accepted this revision.Nov 8 2019, 1:29 PM
This revision is now accepted and ready to land.Nov 8 2019, 1:29 PM
Closed by commit R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow inheriting its private class (authored by ervin). · Explain WhyNov 13 2019, 2:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69673

View Options

src/core/kcoreconfigskeleton.h

Loading...
View Options

src/core/kcoreconfigskeleton.cpp

Loading...
View Options

src/core/kcoreconfigskeleton_p.h

Loading...