Adds a tag selector in the extended filters of the search box.
Selected tag or tags are added to the search query along with the other filters (type, date, rating).
FEATURE: 412564
CCBUG: 356062
elvisangelaccio | |
ngraham |
Dolphin | |
VDG |
Adds a tag selector in the extended filters of the search box.
Selected tag or tags are added to the search query along with the other filters (type, date, rating).
FEATURE: 412564
CCBUG: 356062
No Linters Available |
No Unit Test Coverage |
Buildable 19288 | |
Build 19306: arc lint + arc unit |
Nice, this looks great and works great. Only one real suggestion: disable it when there are no tags. Otherwise clicking on it does nothing.
src/search/dolphinfacetswidget.cpp | ||
---|---|---|
70 | Just tag is fine; the *-symbolic icon names are generally for compatibility with GNOME apps. |
Nice idea! Baloo indexer is failing for me now due to some non-related assert error, so I cannot delete the tags to test it, but will try again.
src/search/dolphinfacetswidget.cpp | ||
---|---|---|
99 ↗ | (On Diff #69418) | this-> not needed. |
256 ↗ | (On Diff #69418) | this-> not needed |
277 ↗ | (On Diff #69418) | Missing reference usage |
src/search/dolphinfacetswidget.h | ||
29 ↗ | (On Diff #69418) | Not needed |
32 ↗ | (On Diff #69418) | Not needed |
93 ↗ | (On Diff #69418) | Initialization not needed, the defautl ctor is automatically called. |
src/search/dolphinfacetswidget.cpp | ||
---|---|---|
140 ↗ | (On Diff #69418) | I totally agree. |