Easier to deploy sonnet: just install the libraries
Details
- Reviewers
dfaure vonreth vkrause - Group Reviewers
Frameworks - Commits
- R246:0c195d0ff947: embed trigrams.map into shared library
make && make test
Diff Detail
- Repository
- R246 Sonnet
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18449 Build 18467: arc lint + arc unit
Easier to deploy, we just need the shared libs and no extra data files (at least not for sonnet itself).
This seems to break several Android builds
https://binary-factory.kde.org/view/Android/job/Koko_android/36/console
Is that because I moved the target to the other cmake file? The generation process should be unchanged.
Ok, I see.
For cross-compiling the trigrams were never generated...
I don't think this is a good idea, but I can guard the resource creation with the same code.
Volker: You are more familiar with the Android stuff, how can we fix that properly? Perhaps like for syntax-highlighting?
I re-scheduled the build, seems to work for me now.
@vkrause : have you some solution to run the trigrams stuff for cross compiles, too?
Given I did break it, sorry for the issue at all ;=)
But still, the fix is not that nice, not trigrams there at all, like before :/