embedd trigrams.map into shared library
ClosedPublic

Authored by cullmann on Nov 2 2019, 7:40 PM.

Details

Summary

Easier to deploy sonnet: just install the libraries

Test Plan

make && make test

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Nov 2 2019, 7:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 2 2019, 7:40 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cullmann requested review of this revision.Nov 2 2019, 7:40 PM

Easier to deploy, we just need the shared libs and no extra data files (at least not for sonnet itself).

vkrause accepted this revision.Nov 3 2019, 7:31 AM
This revision is now accepted and ready to land.Nov 3 2019, 7:31 AM
This revision was automatically updated to reflect the committed changes.
cullmann reopened this revision.Nov 3 2019, 10:44 PM

Is that because I moved the target to the other cmake file? The generation process should be unchanged.

This revision is now accepted and ready to land.Nov 3 2019, 10:44 PM
cullmann planned changes to this revision.Nov 4 2019, 5:58 AM

Ok, I see.
For cross-compiling the trigrams were never generated...
I don't think this is a good idea, but I can guard the resource creation with the same code.

Volker: You are more familiar with the Android stuff, how can we fix that properly? Perhaps like for syntax-highlighting?

I re-scheduled the build, seems to work for me now.

@vkrause : have you some solution to run the trigrams stuff for cross compiles, too?

Thanks for the quick fix!

Given I did break it, sorry for the issue at all ;=)
But still, the fix is not that nice, not trigrams there at all, like before :/

I re-scheduled the build, seems to work for me now.

@vkrause : have you some solution to run the trigrams stuff for cross compiles, too?

D25143 makes it generate the trigram file in my Android setup.

cullmann requested review of this revision.Nov 4 2019, 7:14 PM

Ok, then first close this.

This revision is now accepted and ready to land.Nov 4 2019, 7:14 PM
cullmann closed this revision.Nov 4 2019, 7:14 PM