Depends on D25058
Details
Details
- Reviewers
dfaure apol - Group Reviewers
Frameworks - Commits
- R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog
Diff Detail
Diff Detail
- Repository
- R295 KCMUtils
- Branch
- useaboutplugindialog
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18327 Build 18345: arc lint + arc unit
src/kpluginselector.cpp | ||
---|---|---|
799–803 | Can you guard for nullptr? |
src/kpluginselector.cpp | ||
---|---|---|
799–803 | The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks. So IMHO this code is working in promised conditions, if they are not met, something else is principally broken. |