Differential D25059

KPluginSelector: use new KAboutPluginDialog
ClosedPublic
Actions

Authored by kossebau on Oct 29 2019, 8:04 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
Frameworks
Commits
R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog
Summary

Depends on D25058

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Oct 29 2019, 8:04 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 29 2019, 8:04 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Oct 29 2019, 8:04 PM
anthonyfieroni added a subscriber: anthonyfieroni.Oct 30 2019, 5:37 AM
anthonyfieroni added inline comments.
src/kpluginselector.cpp
799–803

Can you guard for nullptr?

kossebau added inline comments.Oct 30 2019, 2:02 PM
src/kpluginselector.cpp
799–803

The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks.
We should be relatively safe here, as the slot should be only triggered if the "About" button was clicked, in which case the button has the focus, and such will focusedIndex() deliver a valid index.

So IMHO this code is working in promised conditions, if they are not met, something else is principally broken.

dfaure accepted this revision.Nov 20 2019, 8:48 AM
This revision is now accepted and ready to land.Nov 20 2019, 8:48 AM
Closed by commit R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog (authored by kossebau). · Explain WhyNov 24 2019, 12:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpluginselector.cpp (31 lines)

Diff 70260

View Options

src/kpluginselector.cpp

Loading...